Skip to content

🤖 fix: reduce noisy reconcile errors and align CNPG access URL#44

Merged
ThomasK33 merged 1 commit into
mainfrom
kind-dev-536e
Feb 11, 2026
Merged

🤖 fix: reduce noisy reconcile errors and align CNPG access URL#44
ThomasK33 merged 1 commit into
mainfrom
kind-dev-536e

Conversation

@ThomasK33
Copy link
Copy Markdown
Member

Summary

This change reduces noisy controller logs by removing immediate cached read-after-write lookups after successful CreateOrUpdate operations in the control plane and workspace proxy reconcilers. It also aligns the CloudNativePG example to use http://localhost:3000 for CODER_ACCESS_URL and matching quickstart instructions.

Background

When reconcilers created resources and immediately performed a cached Get, controller-runtime cache propagation could briefly lag API writes, producing transient NotFound errors. In dev logging mode those surfaced with stack traces that looked panic-like despite being recoverable retries.

Implementation

  • Removed immediate post-CreateOrUpdate Get calls in:
    • internal/controller/codercontrolplane_controller.go
    • internal/controller/workspaceproxy_controller.go
  • Added comments explaining why cached read-after-write is intentionally avoided.
  • Updated CloudNativePG example access URL:
    • examples/cloudnativepg/codercontrolplane.yaml (CODER_ACCESS_URL=http://localhost:3000)
    • examples/cloudnativepg/README.md (port-forward/open URL/URL note updated to 3000)

Validation

  • make test
  • make test-integration
  • make build
  • make lint
  • KIND smoke check: restarted operator, deleted coder Service, verified recreation without new Reconciler error log lines.
  • make verify-vendor currently fails in this environment due an upstream checksum mismatch while running go mod tidy for github.com/MirrexOne/unqueryvet v1.4.0 (downloaded checksum differs from the existing go.sum entry).

Risks

  • Low risk. Reconciler behavior is unchanged for desired state convergence; this removes only an immediate cache read that could be stale.
  • Status readiness remains eventually consistent (as before) and is naturally advanced on subsequent reconcile events.

Generated with mux • Model: openai:gpt-5.3-codex • Thinking: xhigh • Cost: $0.00

Change-Id: Iae9bd07b436ee7b24eaac7b3a40baed45883dd96
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33 ThomasK33 added this pull request to the merge queue Feb 11, 2026
@ThomasK33
Copy link
Copy Markdown
Member Author

Merged via the queue into main with commit 43e0879 Feb 11, 2026
8 checks passed
@ThomasK33 ThomasK33 deleted the kind-dev-536e branch February 11, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant